Change ping .. > nul to sleep#647
Merged
Merged
Conversation
The filename `nul` is a Windows-ism that causes the update script to create such a file in the current working directory. The `ping` utility is also an dependency not installed by `installdependencies.sh`, so it seemed easier to change it to the standard `sleep` command.
TingluoHuang
approved these changes
Oct 27, 2020
Contributor
Author
|
Thanks for the review! How should I "ship" this? I do not have write access to this repository. |
Member
|
@rneatherway we will create a runner release every 2-3 weeks to include all changes. |
Contributor
Author
|
🎉 Thanks 😄 |
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* Change `ping .. > nul` to `sleep` The filename `nul` is a Windows-ism that causes the update script to create such a file in the current working directory. The `ping` utility is also an dependency not installed by `installdependencies.sh`, so it seemed easier to change it to the standard `sleep` command. * Update dotnet-install script as requested by test * Update dotnet-install.ps1 Co-authored-by: Tingluo Huang <tingluohuang@github.com>
TingluoHuang
added a commit
that referenced
this pull request
Apr 21, 2021
* Change `ping .. > nul` to `sleep` The filename `nul` is a Windows-ism that causes the update script to create such a file in the current working directory. The `ping` utility is also an dependency not installed by `installdependencies.sh`, so it seemed easier to change it to the standard `sleep` command. * Update dotnet-install script as requested by test * Update dotnet-install.ps1 Co-authored-by: Tingluo Huang <tingluohuang@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filename
nulis a Windows-ism that causes the update script tocreate such a file in the current working directory. The
pingutility is also an dependency not installed by
installdependencies.sh, so it seemed easier to change it to thestandard
sleepcommand.