Fix JetBrains Runtime release pagination - #1218
Merged
brunoborges merged 3 commits intoAug 5, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes JetBrains Runtime release pagination so that stable/EA filtering does not incorrectly terminate pagination when a non-empty GitHub releases page contains only the opposite release class.
Changes:
- Switch JetBrainsRuntime release listing to follow GitHub’s
Link: rel="next"pagination instead ofpage=indexing, terminating only on an empty raw page or missing next link. - Add origin validation for pagination links and a
MAX_PAGINATION_PAGESsafeguard warning/termination. - Add regression tests covering stable-after-prerelease, EA-after-stable, raw empty-page termination, safeguard limit, and unexpected-origin pagination links; regenerate
dist/setup.
Show a summary per file
| File | Description |
|---|---|
| src/distributions/jetbrains/installer.ts | Implements rel="next"-driven pagination with origin validation and a page-count safeguard while preserving stable/EA filtering behavior. |
| tests/distributors/jetbrains-installer.test.ts | Adds targeted regression tests to ensure pagination continues across non-matching pages and terminates only on true end-of-pagination conditions/safeguards. |
| dist/setup/282.index.js | Regenerated build output reflecting the updated JetBrains pagination logic. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix JetBrains Runtime release pagination so client-side stable/EA filtering cannot be mistaken for the end of the GitHub result set.
rel="next"link and stop only when the raw page is empty or GitHub provides no next page.MAX_PAGINATION_PAGESand warn if the limit is reached.GITHUB_TOKENbehavior, asset probing, and platform/architecture mapping.dist/setupfrom the fork workflow's uploaded build artifact.Related issue:
Closes #1215
Validation:
Check dist/workflow: https://github.com/jdubois/setup-java/actions/runs/31011030734dist/check passed.brace-expansion@5.0.9, so validation ran on GitHub-hosted runners without changing dependencies.Check list:
npm run checklocally (format, lint, build, test) and all checks pass. (Blocked by the configured package proxy; equivalent validation passed on GitHub-hosted runners.)