Skip to content

Conversation

@shirve2312
Copy link

@shirve2312 shirve2312 commented May 21, 2020

Thank you for sending in this pull request. Please make sure you take a look at the contributing file. Here's a few things for you to consider in this pull request:

  • Include a good description of the workflow.
  • Links to the language or tool will be nice (unless its really obvious)

In the workflow and properties files:

  • The workflow filename of CI workflows should be the name of the language or platform, in lower case. Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").

    The workflow filename of publishing workflows should be the name of the language or platform, in lower case, followed by "-publish".

  • Includes a matching ci/properties/*.properties.json file.

  • Use sentence case for the names of workflows and steps, for example "Run tests".

  • The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")

  • Include comments in the workflow for any parts that are not obvious or could use clarification.

  • CI workflows should run on push to branches: [ master ] and pull_request to branches: [ master ].

    Packaging workflows should run on release with types: [ created ].

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or

    This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:

    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • This workflow must not send data to any 3rd party service except for the purposes of installing dependencies.

  • This workflow must not use a paid service or product.

@shirve2312
Copy link
Author

update aws file

@shirve2312 shirve2312 closed this May 21, 2020
Copy link
Author

@shirve2312 shirve2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@shirve2312 shirve2312 reopened this May 21, 2020
@shirve2312
Copy link
Author

updated

Copy link
Author

@shirve2312 shirve2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@andymckay
Copy link
Contributor

These changes don't make any sense to me so I'm closing. If you can explain them to us in more detail, that might help, thanks.

@andymckay andymckay closed this May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants