-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Update aws.yml #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws.yml #519
Conversation
|
update aws file |
shirve2312
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
|
updated |
shirve2312
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
|
These changes don't make any sense to me so I'm closing. If you can explain them to us in more detail, that might help, thanks. |
Thank you for sending in this pull request. Please make sure you take a look at the contributing file. Here's a few things for you to consider in this pull request:
In the workflow and properties files:
The workflow filename of CI workflows should be the name of the language or platform, in lower case. Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
The workflow filename of publishing workflows should be the name of the language or platform, in lower case, followed by "-publish".
Includes a matching
ci/properties/*.properties.jsonfile.Use sentence case for the names of workflows and steps, for example "Run tests".
The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")
Include comments in the workflow for any parts that are not obvious or could use clarification.
CI workflows should run on
pushtobranches: [ master ]andpull_requesttobranches: [ master ].Packaging workflows should run on
releasewithtypes: [ created ].Some general notes:
This workflow must only use actions that are produced by GitHub, in the
actionsorganization, orThis workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
This workflow must not send data to any 3rd party service except for the purposes of installing dependencies.
This workflow must not use a paid service or product.