Skip to content

feat: optional approval comment for data export approve - #656

Merged
Seechi-Yolo merged 1 commit into
mainfrom
feat-3047-workflow-approval-comments
Jul 29, 2026
Merged

feat: optional approval comment for data export approve#656
Seechi-Yolo merged 1 commit into
mainfrom
feat-3047-workflow-approval-comments

Conversation

@LordofAvernus

@LordofAvernus LordofAvernus commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

User description

关联的 issue

https://github.com/actiontech/sqle-ee/issues/3047

描述你的变更

  • 工单审批意见按节点留痕:通过选填、驳回必填,详情节点回读
  • SQL 上线与数据导出审批语义对齐;导出 Approve 兼容无 body
  • 前端通过确认窗与进度区意见展示(CE/EE 已拆分同步)

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 新增数据导出审批可选意见字段

  • 支持无 body 请求的兼容逻辑

  • 增加审批意见字符验证逻辑

  • 修改业务层接口传递审批信息


Diagram Walkthrough

flowchart LR
  A["前端请求审批"]
  B["Controller处理请求"]
  C["校验审批意见字符数"]
  D["业务层审批接口调用"]
  E["审批操作完成"]
  A -- "请求提交" --> B
  B -- "判断 ContentLength" --> C
  C -- "通过验证" --> D
  D -- "传递审批意见" --> E
Loading

File Walkthrough

Relevant files
Enhancement
data_export_workflow.go
增加审批Payload类型及接口请求更新                                                                         

api/dms/service/v1/data_export_workflow.go

  • 新增ApproveDataExportWorkflowPayload用于存储审批意见
  • 更新ApproveDataExportWorkflowReq,增加Payload字段
+7/-0     
dms_controller.go
兼容空body及审批意见校验处理                                                                                 

internal/apiserver/service/dms_controller.go

  • 增加无 body 情况下直接使用路径参数逻辑
  • 添加审批意见字符验证(不超过255字符)
+17/-3   
data_export_workflow_ce.go
更新审批接口签名,添加审批意见参数                                                                               

internal/dms/biz/data_export_workflow_ce.go

  • 修改ApproveDataExportWorkflow函数签名
  • 新增reason参数用于传递审批意见
+1/-1     
data_export_workflow.go
传递审批意见参数至业务层                                                                                         

internal/dms/service/data_export_workflow.go

  • 调整调用业务层审批接口参数
  • 传递新增reason参数以记录审批意见
+1/-1     

Support empty body Approve via Param path inject; persist optional payload.reason on steps.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@Seechi-Yolo
Seechi-Yolo merged commit e37dd3a into main Jul 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants