feat: optional approval comment for data export approve - #656
Merged
Conversation
Support empty body Approve via Param path inject; persist optional payload.reason on steps. Co-authored-by: Cursor <cursoragent@cursor.com>
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Seechi-Yolo
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/sqle-ee/issues/3047
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
新增数据导出审批可选意见字段
支持无 body 请求的兼容逻辑
增加审批意见字符验证逻辑
修改业务层接口传递审批信息
Diagram Walkthrough
File Walkthrough
data_export_workflow.go
增加审批Payload类型及接口请求更新api/dms/service/v1/data_export_workflow.go
ApproveDataExportWorkflowPayload用于存储审批意见ApproveDataExportWorkflowReq,增加Payload字段dms_controller.go
兼容空body及审批意见校验处理internal/apiserver/service/dms_controller.go
data_export_workflow_ce.go
更新审批接口签名,添加审批意见参数internal/dms/biz/data_export_workflow_ce.go
ApproveDataExportWorkflow函数签名reason参数用于传递审批意见data_export_workflow.go
传递审批意见参数至业务层internal/dms/service/data_export_workflow.go
reason参数以记录审批意见