Skip to content

feat: sync KingBase datasource type and default schema to ODC - #666

Merged
Seechi-Yolo merged 1 commit into
mainfrom
feat-964-odc-kingbase
Aug 14, 2026
Merged

feat: sync KingBase datasource type and default schema to ODC#666
Seechi-Yolo merged 1 commit into
mainfrom
feat-964-odc-kingbase

Conversation

@LordofAvernus

@LordofAvernus LordofAvernus commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

User description

关联的 issue

https://github.com/actiontech/dms-ee/issues/964

描述你的变更

  • Map KingBase to KINGBASE and require database_name
  • Pass database_name as DefaultSchema when opening SQL workbench

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

Made with Cursor


Description

  • 添加 KingBase 类型映射与默认 Schema 设置

  • 强制校验 database_name 参数有效性

  • 更新 SQL Workbench 数据源处理逻辑

  • 增加 KingBase 相关单元测试验证


Diagram Walkthrough

flowchart LR
  A["常量定义更新"] -- 修改 --> B["SQL Workbench 服务调整"]
  B -- 调用 --> C["单元测试验证"]
Loading

File Walkthrough

Relevant files
Enhancement
const.go
更新常量映射增加 KingBase 支持                                                                         

internal/dms/pkg/constant/const.go

  • 添加 KingBase 分支检测
  • 新增 DBTypeKingBase 常量定义
+3/-0     
sql_workbench_service.go
调整 SQL Workbench 逻辑支持 KingBase                                                     

internal/sql_workbench/service/sql_workbench_service.go

  • 添加 KingBase 数据库名称参数校验
  • 设定 KingBase 默认 Schema 为 database_name
  • 增加 KingBase 转换映射逻辑
  • 修改支持类型判断增加 KingBase
+14/-1   
Tests
const_test.go
追加 KingBase 测试场景                                                                                 

internal/dms/pkg/constant/const_test.go

  • 增加 KingBase 类型解析测试用例
+1/-0     
sql_workbench_service_test.go
添加 KingBase 功能与回归测试                                                                           

internal/sql_workbench/service/sql_workbench_service_test.go

  • 新增 KingBase 功能测试覆盖正负路径
  • 包含 MySQL 回归测试验证
+85/-0   

Map KingBase to KINGBASE, require database_name, and pass it as DefaultSchema
when opening the SQL workbench.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@Seechi-Yolo
Seechi-Yolo merged commit 8958aaf into main Aug 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants