feat: sync GBase-8a datasource type and default schema to ODC - #667
Merged
Conversation
Map KingBase to KINGBASE, require database_name, and pass it as DefaultSchema when opening the SQL workbench. Co-authored-by: Cursor <cursoragent@cursor.com>
Map product type GBase-8a to GBASE_8A alongside KingBase, require AdditionalParams.database as DefaultSchema, and default vcName to vc1. Co-authored-by: Cursor <cursoragent@cursor.com>
PR Reviewer Guide 🔍(Review updated until commit e9b1948)
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Persistent review updated to latest commit e9b1948 |
Seechi-Yolo
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/dms-ee/issues/965
描述你的变更
DBTypeGBase8a/ ParseDBTypeGBase-8a→GBASE_8A;database→DefaultSchema;VC→jdbcUrlParameters.vcName(缺省 vc1)feat-964-odc-kingbase;与 KingBase 映射并存(非_ee文件走 CE PR,对齐 check-pr-files)确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docMade with Cursor
Description
增加 KingBase 数据源类型解析及常量定义
为 GBase-8a 数据源设置默认 Schema 且构建 JDBC 参数
修改 SQL Workbench 服务逻辑以支持新数据源类型
添加完善相关测试用例以验证新功能
Diagram Walkthrough
File Walkthrough
const.go
修改数据源类型解析与常量定义internal/dms/pkg/constant/const.go
sql_workbench_service.go
增加 SQL Workbench 新数据源支持逻辑internal/sql_workbench/service/sql_workbench_service.go
const_test.go
增加数据源类型解析测试internal/dms/pkg/constant/const_test.go
sql_workbench_service_test.go
添加新数据源支持测试用例internal/sql_workbench/service/sql_workbench_service_test.go