Fix bugs with caching and format validation when importing files#204
Merged
Fivell merged 2 commits intoactiveadmin-plugins:masterfrom Apr 8, 2026
Conversation
Skumring
force-pushed
the
Fix-bugs-with-caching-and-format-validation-when-importing-files
branch
from
c689419 to
00c6464
Compare
Fivell
requested changes
Apr 7, 2026
| validate :file_contents_present, if: ->(me) { me.file.present? } | ||
|
|
||
| before_validation :unzip_file, if: ->(me) { me.archive? && me.allow_archive? } | ||
| before_validation :encode_file, if: ->(me) { me.force_encoding? && me.file.present? } |
Member
There was a problem hiding this comment.
@Skumring i think after_validation will run even if there are validation errors, lets improve it with
after_validation :encode_file, if: ->(me) { me.errors.empty? && me.force_encoding? &&
me.file.present? }
Skumring
force-pushed
the
Fix-bugs-with-caching-and-format-validation-when-importing-files
branch
from
00c6464 to
89a841d
Compare
Fivell
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: File caching issue - form reuses cached file after validation error
Short Description
When submitting the import form after a validation error, the system reuses the previously cached file instead of showing the "no file" error when no file is selected. This causes confusion and potential unintended data imports.
For more details, see #205
Bug 2: File format validation occurs after encoding when using auto force_encoding
Short Description
When
force_encoding: :autois configured, the file encoding process runs BEFORE file format validation. This causes the system to attempt encoding operations on invalid file formats (e.g.,.txtfiles), leading to unnecessary processing overhead and incorrect error handling flow.For more details, see #206
Local tests result