Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts the v6.0.0 release. Bumps
lib/active_admin_import/version.rbfrom5.1.0→6.0.0and adds the changelog entry covering everything that landed since v5.1.0, plus a backfilled v5.1.0 entry that was missing fromCHANGELOG.md.Why 6.0.0 (and not 5.2.0)
Several breaking changes have accumulated:
activerecord-import< 2.0 are no longer supportedactiverecord-importfloor bumped to >= 2.0 (Bump activerecord-import floor to >= 2.0 #210)instance_eval(&block)toinstance_exec(result, options, &block)(Allow custom ImportResult subclass via :result_class option #214). Zero-arity blocks still work because Ruby procs ignore extra arguments — but anyone declaringdo |x|previously would now receiveresultinstead of nothingThat's enough to warrant a major.
Changelog highlights for 6.0.0
active_admin_import_contextcontroller convention (Add active_admin_import_context convention for controller-provided context #211):result_classoption for plugging in a customImportResultsubclass (Allow custom ImportResult subclass via :result_class option #214)Test plan
lib/active_admin_import/version.rbreads6.0.0CHANGELOG.mdhas entries for both 6.0.0 and the previously-undocumented 5.1.0v6.0.0and push to rubygems