Add MySQL and PostgreSQL to CI database matrix#213
Merged
Conversation
The existing CI matrix runs exclusively against SQLite, which hides any adapter-specific behavior (upsert semantics, conflict targets, column types, etc.). This adds two new CI jobs — one for MySQL 8.0 and one for PostgreSQL 16 — that run the full spec suite against a live database service, using the latest supported Ruby/Rails/ActiveAdmin combination. The adapter is selected by the `DB` env var (sqlite | mysql | postgres). The test Rails app is cached per-adapter (`spec/rails/rails-<ver>-<db>`) and the Gemfile loads the matching driver conditionally. Host, port, and credentials are all driven from env vars so the same setup works locally and in CI.
The MySQL and PostgreSQL jobs were named just "DB mysql" / "DB postgres", which hides the Ruby/Rails/ActiveAdmin combination they run against. The SQLite matrix jobs also didn't mention "SQLite" anywhere. Rename all three job groups so the PR checks list shows exactly what's being tested at a glance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing CI matrix runs exclusively against SQLite, which hides any adapter-specific behavior (upsert semantics, conflict targets, column types, etc.). This adds two new CI jobs — one for MySQL 8.0 and one for PostgreSQL 16 — that run the full spec suite against a live database service, using the latest supported Ruby/Rails/ActiveAdmin combination.
The adapter is selected by the
DBenv var (sqlite | mysql | postgres). The test Rails app is cached per-adapter (spec/rails/rails-<ver>-<db>) and the Gemfile loads the matching driver conditionally. Host, port, and credentials are all driven from env vars so the same setup works locally and in CI.