warn: supported browser #3421
Merged
warn: supported browser #3421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoschilling
force-pushed
the
supported_browsers
branch
from
7fd6989 to
1106b0b
Compare
Contributor
There was a problem hiding this comment.
What does super do here?
Contributor
|
Could you rebase this on master? It can no longer be cleanly merged. |
for example to access user agent from arbre views
timoschilling
force-pushed
the
supported_browsers
branch
from
1106b0b to
91b6440
Compare
timoschilling
force-pushed
the
supported_browsers
branch
from
5af5803 to
67e239c
Compare
Member
Author
|
implemented suggestions and rebased |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the implementation for #2678