Add the ability to customize the footer. #4641
Conversation
varyonic
left a comment
varyonic
left a comment
There was a problem hiding this comment.
My preference would be to enable use of a partial but I am fine with this.
timoschilling
left a comment
timoschilling
left a comment
There was a problem hiding this comment.
I agree with @varyonic, a partial is a better way.
|
what if this already works? ActiveAdmin.application.footer = proc { render_to_string partial: 'footer' }but I haven't check |
|
@blimmer, ping |
|
I haven't had time to look into a partial and am not sure my timeline on availability to look. If this solution isn't acceptable it might make sense to close this PR and open an issue to track that implementation. |
|
I mentioned preferring a partial, but I do think this is acceptable. |
|
Agreed - it seemed like the investigation / implementation of the partial was blocking from the requested changes indication on the PR |
|
I close this PR, it should be implemented as parial or proc |
|
@timoschilling I'm disappointed. Next time I won't suggest a preference when I approve. |
|
Agreed. This implementation is better than what we have now (which is no ability to customize the footer at all), IMO. |
timoschilling
dismissed stale reviews from varyonic and themself
let us discuss this again
timoschilling
requested review from
Fivell,
ccallebs,
deivid-rodriguez,
timoschilling and
varyonic
Fivell
left a comment
Fivell
left a comment
There was a problem hiding this comment.
for me common scenario is put company copyrights to footer , that almost always in this format
Company name - start year - current year.
So I can't use and still need monkey-patch this because current year should be evaluated
docs/1-general-configuration.md
Outdated
|
|
||
| ## Footer Customization | ||
|
|
||
| By default, Active Admin displayed a "Powered by ActiveAdmin" message on every |
There was a problem hiding this comment.
...Active Admin displays...
| # == Footer | ||
| # | ||
| # By default, the footer shows the current Active Admin version. You can | ||
| # override the content of the fotter here. |
varyonic
left a comment
varyonic
left a comment
There was a problem hiding this comment.
This PR supports using a proc.
By default, it will still default to the "Powered by Active Admin <version>", but this allows folks to customize that message.
varyonic
force-pushed
the
feature/add-to-footer
branch
from
7c16ae6 to
c30dd56
Compare
|
Fixed a couple of typos, squashed and force-rebased. |
|
closes #4758 |
|
Maybe some can make a PR to add the proc support in the docs and the initializer template |
| @@ -0,0 +1,28 @@ | |||
| Feature: Site title | |||
|
Agreed, though much of this was copied from Greg's original site_title where this is not documented either. |
|
This is a nice improvement, thanks Ben and friends! |
|
Ironically this was one of the topics of an old post by Philippe. |
5 participants
By default, it will still default to the "Powered by Active Admin
<version>", but this allows folks to customize that message.We wanted to append additional environmental information to better understand bug reports from our internal customers. To accomplish this today, I created
app/admin/footer.rb, but it would be nice to set this as a configuration value.In determining how to do this with my app, I found several resources (stack overflow, gists, blog posts) which indicated to me that this would be a useful feature for people.