Vendor rails-ujs ESM JS #8217
Merged
Vendor rails-ujs ESM JS #8217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8217 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4017 4017
=======================================
Hits 3981 3981
Misses 36 36 ☔ View full report in Codecov by Sentry. |
With this we avoid any files from CDN and issues with CSP. We intended to do this originally but couldn't get it to work. The docs in importmaps-rails were corrected this past week to show what to do in this case. Previously, I was setting the "to:" with the vendor path but it's unnecessary which is why it didn't work.
javierjulio
force-pushed
the
vendor-rails-ujs-esm
branch
from
5b8387c to
cdad9b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, I had tried this but ran into issues pinning to a file with the vendor path specified. The problem was that the vendor path doesn't need to be specified but that's what was listed in the importmap-rails documentation. The docs were corrected this week so this now works as expected. We prefer to vendor this file rather than rely on CDN or the gem bundled version which the latter could be different and potentially non-ESM.
Closes #8216