Add Rails 8.1.0 compatibility #8837

tagliala · 2025-10-22T14:06:50Z

Update ActiveAdmin routing code to use keyword arguments
(**options_hash) for methods such as namespace and get, addressing
deprecation warnings introduced in Rails 8.1 and ensuring compatibility
with Rails 8.2+. Previously, hash options were passed as positional
arguments, which will be unsupported in future Rails releases.

This change affects route definition logic in ActiveAdmin::Router,
including namespace and custom page actions. All routing methods now
use keyword arguments for options, improving code clarity and
future-proofing against Rails upgrades.

Ref: rails/rails#53689

tagliala · 2025-10-22T14:09:23Z

Failures:

  1) Routing route_options with a custom path set in route_options should route using the custom path
     Failure/Error:
       router.namespace namespace.name, namespace.route_options.dup do
         router.root namespace.root_to_options.merge(to: namespace.root_to, as: :root)
       end
     
     ActiveSupport::DeprecationException:
       DEPRECATION WARNING: namespace received a hash argument path. Please use a keyword instead. Support to hash argument will be removed in Rails 8.2. (called from block in ActiveAdmin::Router#define_root_routes at /Users/geremia/dev/activeadmin/lib/active_admin/router.rb:24)

tagliala · 2025-10-22T15:03:03Z

rails/rails#53689

rails/rails@a6d199e283

Copilot

Pull Request Overview

This PR updates the project to test against Rails 8.1.0 while maintaining Rails 8.0.0 compatibility. The changes modernize routing syntax to align with Rails 8.1 conventions and add the new rails_81 test configuration.

Updates Rails version from 8.0.0 to 8.1.0 in main Gemfile and test templates
Modernizes routing syntax with keyword arguments and forwarding operators
Adds rails_80 as a separate test matrix configuration with dependency management

Reviewed Changes

Copilot reviewed 7 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tasks/test_application.rb	Updates app name and adds skip-bundler-audit flag for Rails 8.1
tasks/bug_report_template.rb	Updates Rails version in bug report template to 8.1.0
lib/active_admin/router.rb	Modernizes routing syntax with keyword arguments and argument forwarding
gemfiles/rails_80/Gemfile	Adds new Gemfile for testing Rails 8.0.0 compatibility
Gemfile	Updates main Rails version to 8.1.0
.github/workflows/ci.yaml	Adds rails_81 to test matrix and updates conditional logic
.github/dependabot.yml	Adds dependency management configuration for rails_80 Gemfile

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-10-22T15:17:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (213360c) to head (39d955a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8837   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         139      139           
  Lines        4046     4046           
=======================================
  Hits         4009     4009           
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tagliala · 2025-10-22T15:23:57Z

lib/active_admin/router.rb

          router.root namespace.root_to_options.merge(to: namespace.root_to)
        else
-          router.namespace namespace.name, namespace.route_options.dup do
+          router.namespace namespace.name, **namespace.route_options.dup do


production change.

dup may still be needed to avoid nested objects in route options

tagliala · 2025-10-22T15:24:04Z

lib/active_admin/router.rb

    def page_routes(config)
      page = config.underscored_resource_name
-      router.get "/#{page}" => "#{page}#index"
+      router.get "/#{page}", to: "#{page}#index"


production change.

tagliala · 2025-10-22T15:24:14Z

lib/active_admin/router.rb


    def define_namespace(config)
-      router.namespace config.namespace.name, config.namespace.route_options.dup do
+      router.namespace config.namespace.name, **config.namespace.route_options.dup do


production change.

dup may still be needed to avoid nested objects in route options

tagliala · 2025-10-22T15:24:37Z

lib/active_admin/router.rb

+    def build_route(verbs, ...)
+      Array.wrap(verbs).each { |verb| router.send(verb, ...) }


production change. this will allow to forward both Strings and Hashes

tagliala · 2025-10-22T15:25:30Z

tasks/test_application.rb

        --skip-active-storage
        --skip-bootsnap
        --skip-brakeman
+        --skip-bundler-audit


Update ActiveAdmin routing code to use keyword arguments (`**options_hash`) for methods such as `namespace` and `get`, addressing deprecation warnings introduced in Rails 8.1 and ensuring compatibility with Rails 8.2+. Previously, hash options were passed as positional arguments, which will be unsupported in future Rails releases. This change affects route definition logic in `ActiveAdmin::Router`, including namespace and custom page actions. All routing methods now use keyword arguments for options, improving code clarity and future-proofing against Rails upgrades. Ref: rails/rails#53689

mgrunberg

LGTM

javierjulio

Thanks! I normally wouldn't include this in the changelog but I think it's worthwhile due to the routing changes even though it should be transparent to users.

tagliala · 2025-10-23T15:25:26Z

Should this be backported to 3-stable ?

mgrunberg · 2025-10-23T16:28:13Z

Should this be backported to 3-stable ?

I would love to have it in v3. Do you have time to do the backport? If not I can work on that but next week.

tagliala · 2025-10-23T19:12:24Z

3-0-stable requires Ruby >= 2.6

s.required_ruby_version = ">= 2.6"

I guess that this will not allow (...)

mgrunberg · 2025-10-23T20:33:21Z

3-0-stable requires Ruby >= 2.6

s.required_ruby_version = ">= 2.6"

I guess that this will not allow (...)

I think that operator got introduced in ruby 2.7, right?

I asked @javierjulio this morning and it should be ok to drop ruby 2.6 support in v3 if that blocks Rails 8.1 usage.

We also talked about using conditional code based on ruby version but it may be hard to read in this case.

tagliala force-pushed the feature/rails-81 branch from c19f8c5 to 612a65f Compare October 22, 2025 15:13

tagliala requested a review from Copilot October 22, 2025 15:15

Copilot AI reviewed Oct 22, 2025

View reviewed changes

tagliala commented Oct 22, 2025

View reviewed changes

tagliala marked this pull request as ready for review October 22, 2025 15:25

tagliala requested review from javierjulio and mgrunberg October 22, 2025 15:25

tagliala commented Oct 22, 2025

View reviewed changes

tagliala force-pushed the feature/rails-81 branch from 612a65f to db6f291 Compare October 23, 2025 07:24

tagliala force-pushed the feature/rails-81 branch from db6f291 to 39d955a Compare October 23, 2025 09:12

tagliala changed the title ~~Test against Rails 8.1.0~~ Add Rails 8.1.0 compatibility Oct 23, 2025

mgrunberg approved these changes Oct 23, 2025

View reviewed changes

javierjulio approved these changes Oct 23, 2025

View reviewed changes

javierjulio added the type enhancement label Oct 23, 2025

tagliala merged commit 542d796 into master Oct 23, 2025
31 checks passed

tagliala deleted the feature/rails-81 branch October 23, 2025 15:24

		def build_route(verbs, ...)
		Array.wrap(verbs).each { \|verb\| router.send(verb, ...) }

Uh oh!

Add Rails 8.1.0 compatibility #8837

Add Rails 8.1.0 compatibility #8837

Conversation

tagliala commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tagliala commented Oct 22, 2025

Uh oh!

tagliala commented Oct 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codecov bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tagliala Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

tagliala Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

tagliala Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

tagliala Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

tagliala Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgrunberg left a comment

Choose a reason for hiding this comment

Uh oh!

javierjulio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tagliala commented Oct 23, 2025

Uh oh!

mgrunberg commented Oct 23, 2025

Uh oh!

tagliala commented Oct 23, 2025

Uh oh!

mgrunberg commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tagliala commented Oct 22, 2025 •

edited

Loading

codecov bot commented Oct 22, 2025 •

edited

Loading

tagliala Oct 22, 2025 •

edited

Loading

javierjulio left a comment •

edited

Loading