Fix dependencies rake task to vendor correct ESM files for importmap#8963
Merged
tagliala merged 2 commits intoMar 7, 2026
Merged
Conversation
The task was vendoring the UMD bundle as floating-ui--dom.js, but importmap uses @floating-ui--core.js and @floating-ui--dom.js (ESM browser.mjs files). Update the task to copy the correct ESM browser.mjs files for both @floating-ui/core and @floating-ui/dom, and remove the unused UMD floating-ui--dom.js vendor file. Co-authored-by: tagliala <556268+tagliala@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on removing Flowbite feature in PR #8953
Fix dependencies rake task to vendor correct ESM files for importmap
Mar 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## experimental/feature/remove-flowbite #8963 +/- ##
=====================================================================
Coverage 99.08% 99.08%
=====================================================================
Files 140 140
Lines 4051 4051
=====================================================================
Hits 4014 4014
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1231f35
into
experimental/feature/remove-flowbite
26 checks passed
tagliala
added a commit
that referenced
this pull request
Mar 7, 2026
…8963) * Initial plan * Fix rake task to vendor ESM files matching importmap pins The task was vendoring the UMD bundle as floating-ui--dom.js, but importmap uses @floating-ui--core.js and @floating-ui--dom.js (ESM browser.mjs files). Update the task to copy the correct ESM browser.mjs files for both @floating-ui/core and @floating-ui/dom, and remove the unused UMD floating-ui--dom.js vendor file. Co-authored-by: tagliala <556268+tagliala@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tagliala <556268+tagliala@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dependencies:vendorrake task was copying the UMD bundle (floating-ui.dom.umd.min.js) tovendor/javascript/floating-ui--dom.js, which is neither referenced by the importmap nor the correct format for it. Meanwhile, the ESM files the importmap actually pins (@floating-ui--core.jsand@floating-ui--dom.js) had no automated source.Changes
tasks/dependencies.rake: Replace UMD copy with two ESM copies:@floating-ui/core/dist/floating-ui.core.browser.mjs→vendor/javascript/@floating-ui--core.js@floating-ui/dom/dist/floating-ui.dom.browser.mjs→vendor/javascript/@floating-ui--dom.jsvendor/javascript/floating-ui--dom.js: Delete the UMD file — it was unreferenced and a stale artifact of the old task.The rake task now serves as the authoritative source for regenerating both vendored floating-ui files.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.