Skip to content

Fix dependencies rake task to vendor correct ESM files for importmap#8963

Merged
tagliala merged 2 commits into
experimental/feature/remove-flowbitefrom
copilot/sub-pr-8953-again
Mar 7, 2026
Merged

Fix dependencies rake task to vendor correct ESM files for importmap#8963
tagliala merged 2 commits into
experimental/feature/remove-flowbitefrom
copilot/sub-pr-8953-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 6, 2026

The dependencies:vendor rake task was copying the UMD bundle (floating-ui.dom.umd.min.js) to vendor/javascript/floating-ui--dom.js, which is neither referenced by the importmap nor the correct format for it. Meanwhile, the ESM files the importmap actually pins (@floating-ui--core.js and @floating-ui--dom.js) had no automated source.

Changes

  • tasks/dependencies.rake: Replace UMD copy with two ESM copies:
    • @floating-ui/core/dist/floating-ui.core.browser.mjsvendor/javascript/@floating-ui--core.js
    • @floating-ui/dom/dist/floating-ui.dom.browser.mjsvendor/javascript/@floating-ui--dom.js
  • vendor/javascript/floating-ui--dom.js: Delete the UMD file — it was unreferenced and a stale artifact of the old task.
# Before
FileUtils.cp(
  File.join(node_modules, '@floating-ui', 'dom', 'dist', 'floating-ui.dom.umd.min.js'),
  File.join(vendor, 'floating-ui--dom.js')
)

# After
FileUtils.cp(
  File.join(node_modules, '@floating-ui', 'core', 'dist', 'floating-ui.core.browser.mjs'),
  File.join(vendor, '@floating-ui--core.js')
)
FileUtils.cp(
  File.join(node_modules, '@floating-ui', 'dom', 'dist', 'floating-ui.dom.browser.mjs'),
  File.join(vendor, '@floating-ui--dom.js')
)

The rake task now serves as the authoritative source for regenerating both vendored floating-ui files.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

The task was vendoring the UMD bundle as floating-ui--dom.js,
but importmap uses @floating-ui--core.js and @floating-ui--dom.js
(ESM browser.mjs files). Update the task to copy the correct
ESM browser.mjs files for both @floating-ui/core and @floating-ui/dom,
and remove the unused UMD floating-ui--dom.js vendor file.

Co-authored-by: tagliala <556268+tagliala@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix feedback on removing Flowbite feature in PR #8953 Fix dependencies rake task to vendor correct ESM files for importmap Mar 6, 2026
@tagliala tagliala marked this pull request as ready for review March 7, 2026 09:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (345a2b1) to head (5e9f7e5).
⚠️ Report is 1 commits behind head on experimental/feature/remove-flowbite.

Additional details and impacted files
@@                          Coverage Diff                          @@
##           experimental/feature/remove-flowbite    #8963   +/-   ##
=====================================================================
  Coverage                                 99.08%   99.08%           
=====================================================================
  Files                                       140      140           
  Lines                                      4051     4051           
=====================================================================
  Hits                                       4014     4014           
  Misses                                       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tagliala tagliala merged commit 1231f35 into experimental/feature/remove-flowbite Mar 7, 2026
26 checks passed
@tagliala tagliala deleted the copilot/sub-pr-8953-again branch March 7, 2026 09:55
tagliala added a commit that referenced this pull request Mar 7, 2026
…8963)

* Initial plan

* Fix rake task to vendor ESM files matching importmap pins

The task was vendoring the UMD bundle as floating-ui--dom.js,
but importmap uses @floating-ui--core.js and @floating-ui--dom.js
(ESM browser.mjs files). Update the task to copy the correct
ESM browser.mjs files for both @floating-ui/core and @floating-ui/dom,
and remove the unused UMD floating-ui--dom.js vendor file.

Co-authored-by: tagliala <556268+tagliala@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tagliala <556268+tagliala@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants