3.5: Replace deprecated dialogClass with classes#8978
Merged
tagliala merged 1 commit into3-0-stablefrom Mar 24, 2026
Merged
Conversation
jQuery UI 1.14 sets `$.uiBackCompat` to false by default, which disables the deprecated `dialogClass` option. This caused the `active_admin_dialog` class to no longer be applied to the dialog wrapper, breaking the CSS selector that hides the titlebar close button. Migrate to the classes option, which is the non-deprecated API for adding custom classes to widget elements. Close #8977
tagliala
force-pushed
the
bugfix/8977-unexpected-close-button
branch
from
9229214 to
7baf787
Compare
tagliala
changed the title
dialogClass with classes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8978 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4974
Branches ? 0
=============================================
Hits ? 4934
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jQuery UI 1.14 sets $.uiBackCompat to false by default, which disables the deprecated dialogClass option. This caused the 'active_admin_dialog' class to no longer be applied to the dialog wrapper, breaking the CSS selector that hides the titlebar close button.
Migrate to the classes option, which is the non-deprecated API for adding custom classes to widget elements.
Closes #8977
Screenshot
http://localhost:3000/admin/admin_users > Select All > Delete selected
Before (
3-0-stable)After (this branch)