fix: update stale CSS class names and local dev login#11
Draft
khasinski wants to merge 1 commit intoactiveagents:mainfrom
Draft
fix: update stale CSS class names and local dev login#11khasinski wants to merge 1 commit intoactiveagents:mainfrom
khasinski wants to merge 1 commit intoactiveagents:mainfrom
Conversation
- Rename library__book / book__cover CSS classes to library__report / report__cover to match templates updated in the Writebook-to-Dill rename - Redirect post-login to /reports instead of / (landing page) - Add email/password login form on sign-in page in development mode
|
✅ @khasinski — Superconductor finished — View implementation Standing by for instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
library__book/book__coverclasses inlibrary.cssandbooks.csswere never updated during the Writebook-to-Dill rename. Templates already uselibrary__report/report__cover, so the report grid and "new report" button were invisible due to missing styles./(marketing landing page) instead of/reports. Changedpost_authenticating_urlfallback toreports_url.Rails.env.development?, so local development doesn't require Google OAuth credentials.Test plan
/reportspage shows the report grid and "new report" button/reportsafter sign-in