Skip to content

fix: update stale CSS class names and local dev login #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
khasinski wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: update stale CSS class names and local dev login #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/assets/stylesheets/books.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
}
}

.book__cover {
.report__cover {
background-color: var(--color-bg);
border-radius: 0.3em;
box-shadow: 0 0 0 1px var(--color-subtle-dark);
Expand Down Expand Up @@ -109,14 +109,14 @@
}
}

.book__cover--add {
.report__cover--add {
inset: auto 50% calc(var(--block-space) * -1) auto;
margin-inline-end: calc(var(--btn-size) * -0.5);
position: absolute;
z-index: 1;
}

.book__cover-wrapper {
.report__cover-wrapper {
color: var(--color-always-white);
display: inline-grid;
margin: auto;
Expand All @@ -143,7 +143,7 @@
}
}

.book__cover--remove {
.report__cover--remove {
margin-block-start: calc(var(--block-space) * -1);
z-index: 0;
}
Expand Down
4 changes: 2 additions & 2 deletions app/assets/stylesheets/library.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
padding: var(--gap);
}

.library__book {
.library__report {
--row-gap: calc(var(--block-space) * 0.2);

container-type: inline-size;
Expand All @@ -18,7 +18,7 @@
text-align: center;
}

.library__book--empty {
.library__report--empty {
display: inline-grid;
place-items: center;

Expand Down
2 changes: 1 addition & 1 deletion app/controllers/concerns/authentication.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def authenticated_as(session)
end

def post_authenticating_url
session.delete(:return_to_after_authenticating) || root_url
session.delete(:return_to_after_authenticating) || reports_url
end

def reset_authentication
Expand Down
16 changes: 16 additions & 0 deletions app/views/sessions/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,22 @@
<%= image_tag "https://www.gstatic.com/firebasejs/ui/2.0.0/images/auth/google.svg", size: 24, alt: "Google logo" %>
<span>Sign in with Google</span>
<% end %>

<% if Rails.env.development? %>
<hr class="margin-block">
<p class="txt-subtle margin-block-end">Or sign in with email</p>
<%= form_with url: session_path, class: "form" do |f| %>
<div class="margin-block-end">
<%= f.label :email_address, "Email" %>
<%= f.email_field :email_address, autofocus: true, required: true, class: "input" %>
</div>
<div class="margin-block-end">
<%= f.label :password %>
<%= f.password_field :password, required: true, class: "input" %>
</div>
<%= f.submit "Sign in", class: "btn" %>
<% end %>
<% end %>
</div>

<% content_for(:footer) do %>
Expand Down
Loading