Fix "websocket" example's readme, and make binary names unique#45
Merged
DoumanAsh merged 3 commits intoactix:masterfrom Sep 24, 2018
Merged
Fix "websocket" example's readme, and make binary names unique#45DoumanAsh merged 3 commits intoactix:masterfrom
DoumanAsh merged 3 commits intoactix:masterfrom
Conversation
This should allow running cargo run --bin in the root directory.
DoumanAsh
approved these changes
Sep 18, 2018
Contributor
DoumanAsh
left a comment
DoumanAsh
left a comment
There was a problem hiding this comment.
Oh, thank you, having unique name in each example is certainly better
DoumanAsh
approved these changes
Sep 18, 2018
|
|
||
| [[bin]] | ||
| name = "server" | ||
| name = "rustls-server" |
Contributor
There was a problem hiding this comment.
Should you update cargo run in README?
Contributor
Author
There was a problem hiding this comment.
I think it's ok because there's only one binary in this directory
I get some "No such file or directory" panics when running it from the root directory. I assume that it can't find its TLS key files.
I also get some "No such file" panics (but not the same ones) when running in its own directory, I think it wants a "static" directory to exist.
|
|
||
| [[bin]] | ||
| name = "server" | ||
| name = "tls-server" |
Contributor
There was a problem hiding this comment.
Should you update cargo run in README?
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.