Conversation
Acton strings must always contain valid UTF-8. Functions in str.c rely on this, so we must ensure that B_str is always valid and raise an exception if it is not valid. to$str() and to_str_noc() had incorrect ASCII detection that checked bytes after incrementing the pointer, skipping the first byte. This caused strings starting with non-ASCII bytes (e.g., \xe8\x03) to be misclassified as ASCII, bypassing UTF-8 validation entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acton strings must always contain valid UTF-8. Functions in str.c rely on this, so we must ensure that B_str is always valid and raise an exception if it is not valid.
to$str() and to_str_noc() had incorrect ASCII detection that checked bytes after incrementing the pointer, skipping the first byte. This caused strings starting with non-ASCII bytes (e.g., \xe8\x03) to be misclassified as ASCII, bypassing UTF-8 validation entirely.