Fix build of unused dep#2557
Merged
Merged
Conversation
added 2 commits
December 11, 2025 14:54
This was rather interesting. In a project we can declare dependencies on other projects. Since we now have a total build graph, we only compile modules in dependencies that are actually imported from the main project. What's interesting is that in some cases we depend on things that are entirely unused. In this case, in the sorespo repo, in its gen part, it depends on Orchestron which in turn depends on netconf. In the normal main sorespo build, it uses netconf, but in the gen part, it doesn't use any part of Orchestron that in turn uses netconf and so we end up with no modules compiled in the netconf dep. Then we proceed with the zig build, which then tries to build an archive out of the netconf project but since there are no compiled modules, there are no .c files and thus nothing to link or put together and that's a Zig error. We fix this by adding a dummy file with a dummy function in case we didn't find anything else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was rather interesting. In a project we can declare dependencies on other projects. Since we now have a total build graph, we only compile modules in dependencies that are actually imported from the main project. What's interesting is that in some cases we depend on things that are entirely unused. In this case, in the sorespo repo, in its gen part, it depends on Orchestron which in turn depends on netconf. In the normal main sorespo build, it uses netconf, but in the gen part, it doesn't use any part of Orchestron that in turn uses netconf and so we end up with no modules compiled in the netconf dep. Then we proceed with the zig build, which then tries to build an archive out of the netconf project but since there are no compiled modules, there are no .c files and thus nothing to link or put together and that's a Zig error. We fix this by adding a dummy file with a dummy function in case we didn't find anything else.