Fix LSP stdout framing corruption#2629
Merged
Merged
Conversation
The LSP server communicates over stdio, so any non-protocol output on stdout can corrupt JSON-RPC framing and make VS Code lose sync with messages like "Header must provide a Content-Length property". We had compiler paths that could emit plain text to stdout during LSP-triggered compile work (especially dependency-related output), which can interleave with LSP packets and break parsing. This originated from the compiler legacy where this was all in the old "actonc" that outputted messages meant for human consumption, then we moved it into a common library for use by the LSP-server as well but never removed the messages that were unconditionally printed. We now add conditions to silence messages based on the quiet options or output errors to stderr instead of stdout as to not interfere with the LSP communication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LSP server communicates over stdio, so any non-protocol output on stdout can corrupt JSON-RPC framing and make VS Code lose sync with messages like "Header must provide a Content-Length property".
We had compiler paths that could emit plain text to stdout during LSP-triggered compile work (especially dependency-related output), which can interleave with LSP packets and break parsing. This originated from the compiler legacy where this was all in the old "actonc" that outputted messages meant for human consumption, then we moved it into a common library for use by the LSP-server as well but never removed the messages that were unconditionally printed.
We now add conditions to silence messages based on the quiet options or output errors to stderr instead of stdout as to not interfere with the LSP communication.
Fixes #2627