Adapt progress output to width#2682
Merged
Merged
Conversation
plajjan
force-pushed
the
progress-width-adapt
branch
from
8e61f54 to
0ffe823
Compare
The build and test progress renderers assumed a fixed terminal shape in too many places. Narrow terminals could wrap live rows, live and done lines could fall into different column layouts, and acton test no longer kept its wide padded live format. The test UI could also lose its initial spinner state and stall while repainting live rows. Introduce explicit terminal size tracking and route the build and test formatters through width-aware renderers. Build lines now share one layout picker for live and done output, preserve failure messages as truncated status text, reserve a safety column against autowrap, and still fit to the current width when progress drawing is disabled. Test lines now reuse the legacy wide layout when it fits, fall back compactly when it does not, and render live spinners from indexed line renderers. This keeps build output columnar at normal widths, lets test output preserve its established wide layout while still degrading predictably on narrow terminals, and makes current terminal width an input to rendering rather than an accidental side effect of the progress UI mode.
plajjan
force-pushed
the
progress-width-adapt
branch
from
0ffe823 to
4372471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build and test progress renderers assumed a fixed terminal shape in too many places. Narrow terminals could wrap live rows, live and done lines could fall into different column layouts, and acton test no longer kept its wide padded live format. The test UI could also lose its initial spinner state and stall while repainting live rows.
Introduce explicit terminal size tracking and route the build and test formatters through width-aware renderers. Build lines now share one layout picker for live and done output, preserve failure messages as truncated status text, reserve a safety column against autowrap, and still fit to the current width when progress drawing is disabled. Test lines now reuse the legacy wide layout when it fits, fall back compactly when it does not, and render live spinners from indexed line renderers.
This keeps build output columnar at normal widths, lets test output preserve its established wide layout while still degrading predictably on narrow terminals, and makes current terminal width an input to rendering rather than an accidental side effect of the progress UI mode.
Fixes #2673