Restrict module top-level statements#2728
Merged
Merged
Conversation
plajjan
force-pushed
the
declarative-modules
branch
2 times, most recently
from
26f6079 to
bfb9a98
Compare
The parser has a shared statement grammar across module bodies and nested suites, but the module top level is meant to define constants and declarations rather than execute arbitrary code. This change keeps the shared parser structure and validates parsed module suites afterwards. Only declarations, signatures, and assignments are accepted at the module top level, and top-level assignment names are tracked so rebinding a module constant is rejected early.
plajjan
force-pushed
the
declarative-modules
branch
from
bfb9a98 to
1c0cd76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser has a consistent statement grammar across module bodies and nestes suites so the syntax remains simple with uniform parsing. However, we do in fact want a somewhat stricter grammar on the module top level.
This change keeps the shared parsing structure and validates parsed module suites afterwards. Only declarations, signatures, and assignments are accepted at the module top level, and top-level assignment names are tracked so rebinding a module constant is rejected early. Explicit module docstrings before imports still work, while stray bare strings in module bodies no longer do.
This makes the parser more restrictive only where the language requires it, without splitting module parsing off into a separate statement grammar.