Fix macOS Zig SDK fallback for Homebrew#2938
Merged
Merged
Conversation
Acton already works around the macOS 26 Command Line Tools SDK by pointing Zig at /dev/null for DEVELOPER_DIR. The runtime compile path only did that when DEVELOPER_DIR was unset, though. Homebrew runners can provide a Command Line Tools value, so the installed compiler still let Zig see the macOS 26 SDK and fail while compiling C++ dependencies. Force the fallback for all spawned Zig builds on macOS and apply the same rule to the direct actondb build. Keep the source Homebrew Formula aligned with the tap by installing lsp-server-acton explicitly and excluding dist/bin from prefix.install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.28.0 Homebrew source build can still let Zig see the macOS 26 Command Line Tools SDK when the runner already provides DEVELOPER_DIR. That bypasses the existing fallback and makes the Formula test fail while compiling C++ dependencies through bundled Zig.
This forces the fallback for spawned Zig builds on macOS and applies the same rule to the direct actondb build. It also keeps the in-repo Homebrew Formula aligned with the tap by installing lsp-server-acton explicitly and keeping dist/bin out of prefix.install.