Treat system tydb files as immutable#2945
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 357ea4a533
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bundled base and std interfaces are runtime inputs from the selected Acton system root, not writable caches. Read those LMDB environments without lock-table state so root-owned installs and read-only alternate sysroots do not need to create or update lock.mdb files. Keep project and dependency interfaces on normal LMDB read locking. In dist/base and dist/std, delete LMDB lock files from generated interfaces and make data.mdb world-readable before packaging.
plajjan
force-pushed
the
fix-dist-tydb-readonly
branch
from
357ea4a to
ade6221
Compare
plajjan
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ade62216ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Bundled base and std interface databases are read-only runtime inputs from the selected Acton system root. The compiler now opens those .tydb files with MDB_RDONLY and MDB_NOLOCK whether the root is next to the executable or supplied with --syspath. Project and dependency interface caches keep normal LMDB read locking because they can still be rewritten by concurrent builds.
The dist/base and dist/std build targets remove generated LMDB lock files and normalize data.mdb permissions before packaging, so release tarballs do not ship lock files and their interface databases remain world-readable.