Avoid arm64 parser segfaults#2964
Merged
Merged
Conversation
Concurrent parser evaluation on arm64 can crash in GHC RTS apply stubs when GHC 9.8.4 floats parser subexpressions into shared closures. Compile Acton.Parser with -fno-full-laziness so those parser closures stay local to each parse. This preserves parser and compiler concurrency while avoiding the observed null apply-stub faults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHC 9.8.4 on arm64 can crash in RTS apply stubs when concurrent parser evaluation touches parser closures that full laziness has floated into shared top-level values. Compile Acton.Parser with -fno-full-laziness so those closures stay local to each parse while preserving normal parser and compiler concurrency.
I don't quite know why this hits us just in the parser (or well, at all, bug I guess), but this fix certainly seems to have a good measurable effect and it improves runtime performance ever so slightly, though memory usage increases somewhat.