Add benchmark for AnnulusBounds #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ok, I think this time I didn't mess it up. |
Contributor
|
I like this initiative! |
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=======================================
Coverage 48.67% 48.67%
=======================================
Files 325 325
Lines 16397 16397
Branches 7599 7599
=======================================
Hits 7981 7981
Misses 3104 3104
Partials 5312 5312
Continue to review full report at Codecov.
|
Contributor
|
Why is this labeled as bug? |
paulgessinger
added
Improvement
Member
Author
Because after having opened this PR wrongly two times before this one, I labelled it incorrectly. 😅 |
asalzburger
approved these changes
Jul 16, 2020
Contributor
asalzburger
left a comment
asalzburger
left a comment
There was a problem hiding this comment.
Conditionally approved, if you don't need the other code block, just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a benchmark for the various bounds checks in
AnnulusBounds. I'm following @HadrienG2's example inBoundaryCheckBenchmark.cpp, and pick out a few special points to test best-case and worst-case performance. Also included are random test points.This indicates the covariance check is about 10x slower than the tolerance and absolute checks. (Which is not really unexpected, I just wanted to quantify)