refactor: Segmentizer.cpp : Use a span instead of copying#4926
Merged
kodiakhq[bot] merged 3 commits intoacts-project:mainfrom Dec 20, 2025
Merged
refactor: Segmentizer.cpp : Use a span instead of copying#4926kodiakhq[bot] merged 3 commits intoacts-project:mainfrom
kodiakhq[bot] merged 3 commits intoacts-project:mainfrom
Conversation
Member
|
/ci-bridge-run |
Contributor
Member
|
/ci-bridge-run |
paulgessinger
approved these changes
Dec 19, 2025
Contributor
|
/ci-bridge-run |
|
Collaborator
acts-project-service
added
the
Fails Athena tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: Segmentizer.cpp : Use a span instead of copying
--- END COMMIT MESSAGE ---
This part is confusing from a classical C++ background, it looks like a list of two elements but it is in fact invoking a range copy.
A copy and allocation doesn't seem to be necessary here so it is turned to a span, this makes the intention clearer and should improve performance.