build: Make static builds of Examples, Plugins possible#4947
Merged
kodiakhq[bot] merged 2 commits intoacts-project:mainfrom Jan 9, 2026
Merged
build: Make static builds of Examples, Plugins possible#4947kodiakhq[bot] merged 2 commits intoacts-project:mainfrom
kodiakhq[bot] merged 2 commits intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Fatras
paulgessinger
changed the title
Member
|
Changed titles because this was already possible for the core lib. |
Contributor
paulgessinger
approved these changes
Jan 9, 2026
|
Collaborator
acts-project-service
added
the
Breaks Athena build
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 23, 2026
…#4947) This removes the `SHARED` attribute from calls to `add_library` and `add_acts_library` in Examples and Plugins, in order to allow static builds with setting `BUILD_SHARED_LIBS=OFF` globally. Also fixed ODR violation that popped up in the static build.
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 24, 2026
…#4947) This removes the `SHARED` attribute from calls to `add_library` and `add_acts_library` in Examples and Plugins, in order to allow static builds with setting `BUILD_SHARED_LIBS=OFF` globally. Also fixed ODR violation that popped up in the static build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
SHAREDattribute from calls toadd_libraryandadd_acts_libraryin Examples and Plugins, in order to allow static builds with settingBUILD_SHARED_LIBS=OFFglobally.Also fixed ODR violation that popped up in the static build.
--- END COMMIT MESSAGE ---
@paulgessinger @andiwand