Skip to content

refactor: ActsGeoModelPlugin - Remove geometry context from GeoModelConverters#4982

Merged
kodiakhq[bot] merged 3 commits intoacts-project:mainfrom
junggjo9:ParseCtxGeoFactory
Jan 19, 2026
Merged

refactor: ActsGeoModelPlugin - Remove geometry context from GeoModelConverters#4982
kodiakhq[bot] merged 3 commits intoacts-project:mainfrom
junggjo9:ParseCtxGeoFactory

Conversation

@junggjo9
Copy link
Contributor

@junggjo9 junggjo9 commented Jan 17, 2026

  • Plain geometry context is used in several places which can be factored out
  • Simplify the shift converter

--- END COMMIT MESSAGE ---

@github-actions github-actions bot added this to the next milestone Jan 17, 2026
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Jan 17, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2026

📊: Physics performance monitoring for 700d845

Full contents

physmon summary

@andiwand andiwand requested a review from dimitra97 January 19, 2026 10:01
@sonarqubecloud
Copy link

@kodiakhq kodiakhq bot merged commit 04f512a into acts-project:main Jan 19, 2026
43 checks passed
@junggjo9 junggjo9 deleted the ParseCtxGeoFactory branch January 19, 2026 15:00
@acts-project-service acts-project-service added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Jan 19, 2026
@andiwand andiwand modified the milestones: next, v45.0.0 Jan 29, 2026
JustusRudolph pushed a commit to JustusRudolph/acts that referenced this pull request Feb 23, 2026
…onverters (acts-project#4982)

- Plain geometry context is used in several places which can be factored out
- Simplify the shift converter
JustusRudolph pushed a commit to JustusRudolph/acts that referenced this pull request Feb 24, 2026
…onverters (acts-project#4982)

- Plain geometry context is used in several places which can be factored out
- Simplify the shift converter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaks Athena build This PR breaks the Athena build Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants