Skip to content

build: Improve python handling in cmake#5000

Merged
kodiakhq[bot] merged 4 commits intoacts-project:mainfrom
benjaminhuth:build/cmake-find-python
Jan 22, 2026
Merged

build: Improve python handling in cmake#5000
kodiakhq[bot] merged 4 commits intoacts-project:mainfrom
benjaminhuth:build/cmake-find-python

Conversation

@benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Jan 21, 2026

  • Only look for Developement.Module since Developement only looks for symbols for embeded python usage which are not included in manylinux images
  • Pull find_packages out of ACTS_BUILD_EXAMPLES if-clause.
  • Only build python bindings for examples if ACTS_BUILD_EXAMPLES is enabled.

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

@benjaminhuth benjaminhuth changed the title build: Improve python dependency in cmake build: Improve python handling in cmake Jan 21, 2026
@github-actions github-actions bot added this to the next milestone Jan 21, 2026
paulgessinger
paulgessinger previously approved these changes Jan 21, 2026
@AJPfleger
Copy link
Contributor

image

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

📊: Physics performance monitoring for b0f58bb

Full contents

physmon summary

@sonarqubecloud
Copy link

@kodiakhq kodiakhq bot merged commit 5c3de28 into acts-project:main Jan 22, 2026
43 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [5c3de28]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jan 22, 2026
@andiwand andiwand modified the milestones: next, v45.0.0 Jan 29, 2026
JustusRudolph pushed a commit to JustusRudolph/acts that referenced this pull request Feb 23, 2026
* Only look for `Developement.Module` since `Developement` only looks for symbols for embeded python usage which are not included in manylinux images
* Pull `find_packages` out of `ACTS_BUILD_EXAMPLES` if-clause.
* Only build python bindings for examples if `ACTS_BUILD_EXAMPLES` is enabled.
JustusRudolph pushed a commit to JustusRudolph/acts that referenced this pull request Feb 24, 2026
* Only look for `Developement.Module` since `Developement` only looks for symbols for embeded python usage which are not included in manylinux images
* Pull `find_packages` out of `ACTS_BUILD_EXAMPLES` if-clause.
* Only build python bindings for examples if `ACTS_BUILD_EXAMPLES` is enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaks Athena build This PR breaks the Athena build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants