Skip to content

chore: Update GbtsTrackingFilter to ACTS coding standard#5012

Merged
kodiakhq[bot] merged 4 commits intoacts-project:mainfrom
jpreston-cern:trackFinder_codeUpdates
Jan 28, 2026
Merged

chore: Update GbtsTrackingFilter to ACTS coding standard#5012
kodiakhq[bot] merged 4 commits intoacts-project:mainfrom
jpreston-cern:trackFinder_codeUpdates

Conversation

@jpreston-cern
Copy link
Contributor

This is the fourth in a series of PR's that aim to bring GBTS up to date with ACTS coding standards.

This PR focuses on the comments made about the GbtsTrackingFilter files and aims to update them accordingly, this mainly includes reviewing the use of raw pointers and changing when appropriate.
Other related changes are also made to the files affected by the GbtsTrackingFilter changes.

--- END COMMIT MESSAGE ---

@andiwand @timadye

fix conflicts in geoemtry as well as redelete LUT file
@github-actions github-actions bot added this to the next milestone Jan 27, 2026
@github-actions github-actions bot added Component - Core Affects the Core module Seeding labels Jan 27, 2026
@jpreston-cern
Copy link
Contributor Author

as with the other PR's changes to fixed size variables will be done in the next (and hopefully final) PR on coding standards

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

📊: Physics performance monitoring for 004adee

Full contents

physmon summary

@jpreston-cern jpreston-cern marked this pull request as ready for review January 27, 2026 12:21
@jpreston-cern jpreston-cern deleted the trackFinder_codeUpdates branch January 27, 2026 18:45
@jpreston-cern jpreston-cern restored the trackFinder_codeUpdates branch January 27, 2026 18:47
@jpreston-cern jpreston-cern reopened this Jan 27, 2026
@sonarqubecloud
Copy link

@jpreston-cern
Copy link
Contributor Author

/ci-bridge-run

@kodiakhq kodiakhq bot merged commit d0970d8 into acts-project:main Jan 28, 2026
50 of 52 checks passed
@andiwand andiwand modified the milestones: next, v45.0.0 Jan 29, 2026
JustusRudolph pushed a commit to JustusRudolph/acts that referenced this pull request Feb 23, 2026
…ect#5012)

This is the fourth in a series of PR's that aim to bring GBTS up to date with ACTS coding standards.

This PR focuses on the comments made about the `GbtsTrackingFilter` files and aims to update them accordingly, this mainly includes reviewing the use of raw pointers and changing when appropriate.
Other related changes are also made to the files affected by the `GbtsTrackingFilter` changes.
JustusRudolph pushed a commit to JustusRudolph/acts that referenced this pull request Feb 24, 2026
…ect#5012)

This is the fourth in a series of PR's that aim to bring GBTS up to date with ACTS coding standards.

This PR focuses on the comments made about the `GbtsTrackingFilter` files and aims to update them accordingly, this mainly includes reviewing the use of raw pointers and changing when appropriate.
Other related changes are also made to the files affected by the `GbtsTrackingFilter` changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Core Affects the Core module Seeding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants