feat: adding JsonKindDispatcher + Surface conversion#5195
Merged
kodiakhq[bot] merged 18 commits intoacts-project:mainfrom Apr 8, 2026
Merged
feat: adding JsonKindDispatcher + Surface conversion#5195kodiakhq[bot] merged 18 commits intoacts-project:mainfrom
kodiakhq[bot] merged 18 commits intoacts-project:mainfrom
Conversation
Contributor
Author
|
Introduced an additional overload for boundless surfaces to unify the interface |
Contributor
paulgessinger
approved these changes
Apr 7, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding JsonKindDispatcher that unifies the interface for the json conversion.
Refactoring the Surface json conversion to TypeDispatcher + JsonKindDispatcher flow.
SurfaceJsonConverter is now a class that stores the json encoders/decoders and its Config members.
The class is static, since a lot of external conversion depends on the conversion functions being statically accessible.
Could be refactored later (e.g., refactor all the json converters to classes and pass the surface converter as a Config member).
The kind of the Surface + Bounds type is performed by two independent functions, in case there will be changes to the way the type is handled.
PerigeeSurface is handled independently outside of the dispatcher structure, since it does not follow the usual constructor argument convention.
The said constructor could be added to unify the interface.
The PR also adds GeometryIdentifier conversion with the dedicated converter and fixes the material conversion bug.