Skip to content

build(detray): Increase usability of detray build#5502

Merged
kodiakhq[bot] merged 1 commit into
acts-project:mainfrom
stephenswat:build/detray_cleanup
May 22, 2026
Merged

build(detray): Increase usability of detray build#5502
kodiakhq[bot] merged 1 commit into
acts-project:mainfrom
stephenswat:build/detray_cleanup

Conversation

@stephenswat

@stephenswat stephenswat commented May 22, 2026

Copy link
Copy Markdown
Member

This commit fixes several issues with the detray build system which have been identified when trying to use it through ACTS to build traccc. More specifically, it:

  1. Includes the detray directory directory, without relying on FetchContent. Consequently, removes the ability to use a pre-installed detray.
  2. Ensures that the detray metadata files are always generated and installed.
  3. Removes the dependency on Google Test and Google Benchmark from installed versions of detray.

--- END COMMIT MESSAGE ---

Tagging @paradajzblond @krasznaa; aims to incorporate everything that #5450 does.

This commit fixes several issues with the detray build system which have
been identified when trying to use it through ACTS to build traccc. More
specifically, it:

1. Include the detray directory directory, without relying on
   FetchContent. Consequently, remove the ability to use a pre-installed
   detray.
2. Ensure that the detray metadata files are always generated and
   installed.
3. Remove the dependency on Google Test and Google Benchmark from
   installed versions of detray.

@krasznaa krasznaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good. Hopefully the CI agrees.

@github-actions github-actions Bot added Component - Documentation Affects the documentation Component - Detray Affects the Detray project labels May 22, 2026
@github-actions github-actions Bot added this to the next milestone May 22, 2026
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

📊: Physics performance monitoring for 0b74f7e

Full contents

physmon summary

@kodiakhq kodiakhq Bot merged commit 1c5bad5 into acts-project:main May 22, 2026
61 checks passed
@andiwand andiwand modified the milestones: next, v46.7.0 May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Detray Affects the Detray project Component - Documentation Affects the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants