Skip to content

i2cslave: Fix missing translate() when raising exceptions#1123

Merged
tannewt merged 1 commit into
adafruit:masterfrom
notro:i2cslave_translate_fix
Aug 20, 2018
Merged

i2cslave: Fix missing translate() when raising exceptions#1123
tannewt merged 1 commit into
adafruit:masterfrom
notro:i2cslave_translate_fix

Conversation

@notro
Copy link
Copy Markdown

@notro notro commented Aug 18, 2018

The translate() changes where applied after travis had checked the
i2cslave PR so this wasn't caught.

The translate() changes where applied after travis had checked the
i2cslave PR so this wasn't caught.
@jerryneedell
Copy link
Copy Markdown
Collaborator

jerryneedell commented Aug 18, 2018

FYI - without this PR, the current master fails to build any of the ATMEL boards with errors like this

In file included from ../../shared-bindings/i2cslave/I2CSlave.c:40:0:
../../py/runtime.h:152:15: note: expected 'const compressed_string_t * {aka const struct <anonymous> *}' but argument is of type 'const char *'
 NORETURN void mp_raise_ValueError(const compressed_string_t *msg);
               ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
../../py/mkrules.mk:55: recipe for target 'build-circuitplayground_express_crickit/shared-bindings/i2cslave/I2CSlave.o' failed
make: *** [build-circuitplayground_express_crickit/shared-bindings/i2cslave/I2CSlave.o] Error 1
make: *** Waiting for unfinished jobs....

after including this PR -- all the builds succeed. I have only tried using the metro_m4_express and it seems OK.

Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up! You rock as always.

@tannewt
Copy link
Copy Markdown
Member

tannewt commented Aug 20, 2018

I'm going to merge this because it fixes everything but the translation build. Its verifying all strings are in the .po files for translators. You'll need to run make translate at the top level and do another PR. Thanks!

@tannewt tannewt merged commit ea6b363 into adafruit:master Aug 20, 2018
@notro notro deleted the i2cslave_translate_fix branch February 14, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants