i2cslave: Fix missing translate() when raising exceptions#1123
Merged
Conversation
The translate() changes where applied after travis had checked the i2cslave PR so this wasn't caught.
Collaborator
|
FYI - without this PR, the current master fails to build any of the ATMEL boards with errors like this after including this PR -- all the builds succeed. I have only tried using the metro_m4_express and it seems OK. |
tannewt
approved these changes
Aug 20, 2018
Member
tannewt
left a comment
There was a problem hiding this comment.
Thanks for following up! You rock as always.
Member
|
I'm going to merge this because it fixes everything but the translation build. Its verifying all strings are in the .po files for translators. You'll need to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The translate() changes where applied after travis had checked the
i2cslave PR so this wasn't caught.