Add support for patching newer ASF4 code.#292
Merged
Conversation
This makes it possible to automatically fix newer code.
This is the first automatic update that has caused a few deletions where code was previously copied instead of moved. This is a prerequisite for micropython#260.
dhalbert
approved these changes
Sep 29, 2017
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
The patch stuff is great. I see what you are doing. Is there some way to get git to do it instead by merging? Maybe we'd need a separate ASF4 repo.
| for patch in os.listdir("asf4/patches/" + chip): | ||
| patch = "patches/" + chip + "/" + patch | ||
| print(patch) | ||
| result = subprocess.run(["patch", "-l", "-F", "10", "-u", "-p", "1", "-d", tmp_dir, "-i", "../" + patch]) |
Collaborator
There was a problem hiding this comment.
Doesn't need to be changed, but consider using subprocess.run("some {} command {}".format(...), shell=True) to make the command line easier to change and read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also updates ASF4 to include flash APIs.
This pull is two separate commits to make it easier to see the patching changes from the ASF4 changes.