Add lane marking overlay, rural ditches, and 15 cm urban curbs - #62
Merged
Conversation
- RoadMeshExtruder: add IsUrbanRoadType(), BuildLaneMarkingMesh(), BuildDitchMesh() - RoadMeshExtruder: auto-select UrbanKerbHeight (15cm) for Residential/Service, no kerb + ditch for rural roads - RoadMeshResult: add LaneMarkingMesh, DitchMesh, DitchTextureId fields - RegionTextures: add GetDitchTextureId() returning terrain_grass / terrain_sand / etc - MapSceneBuilder: create LaneMarking and Ditch child GameObjects in BuildRoad() - Tests: update 2 existing kerb tests to use urban road type; add 31 new tests Co-authored-by: adam133 <20442729+adam133@users.noreply.github.com> Agent-Logs-Url: https://github.com/adam133/vectorroad/sessions/200fa58d-9ef0-43a8-bc20-20a267046466
adam133
marked this pull request as ready for review
March 22, 2026 23:53
Copilot
AI
changed the title
[WIP] Ensure lane lines and markers are visible and add ditches
Add lane marking overlay, rural ditches, and 15 cm urban curbs
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaneMarkingTextureIdwas generated but never applied to any renderer, making lane lines invisible. Rural roads lacked roadside geometry entirely, and urban curbs were only 5 cm tall.Lane markings
BuildLaneMarkingMesh()duplicates road surface geometry elevated by 5 mm (LaneMarkingClearance) with UV0 set to lane-marking tiling (6 m repeat) — generated for all paved types (notDirt/Path/Cycleway)MapSceneBuilder.BuildRoad()now creates aLaneMarkingchildGameObjectand applieslane_marking_oneway/lane_marking_twowaymaterialRural ditches (1 m deep)
BuildDitchMesh()generates a V-profile trench on both sides: road edge → bottom (1.5 m out, 1 m below road surface) → outer edge (3 m out, back to road level)RegionTextures.GetDitchTextureId()returns region-appropriate texture (terrain_grass,terrain_sand,terrain_snow,terrain_mud)MapSceneBuildercreates aDitchchildGameObjectfor rural roadsUrban curbs (15 cm)
IsUrbanRoadType()classifiesResidentialandServiceas urban; everything else is ruralUrbanKerbHeight = 0.15fauto-selected for urban roads via theExtrudeWithDetails(RoadType, ...)overload; rural roads getkerbHeight = 0(empty kerb mesh) + ditchRoadMeshResultadditionsOriginal prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.