fix build on WSL Ubuntu 20.04 GCC#32
Merged
Merged
Conversation
added <cstring> header to include memcmp additionally changed <assert.h> to the slightly more modern <cassert>
Owner
|
Thanks for this! I've just merged it in :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a compile error due to
memcmpnot being declared in the scope.OS: WSL Ubuntu 20.04 (hosted on Windows 10 Build 20190.rs_prerelease.200807-1609)
Compiler: GCC 9.3.0
error:
memcmpwas not declared in this scopelet me know if you need any more information on my build environment.
Hopefully, this bug can be replicated. These changes fixed the build on my repo and so I wanted to make sure others didn't have the same problem.
list of changes:
added <cstring> header to include memcmp
not a bug additionally changed <assert.h> to the slightly more c++ esque modern <cassert>