Skip to content

Add tvOS Siri Remote navigation - #128

Merged
adamtheturtle merged 1 commit into
mainfrom
fix/issue-120
Aug 23, 2026
Merged

Add tvOS Siri Remote navigation#128
adamtheturtle merged 1 commit into
mainfrom
fix/issue-120

Conversation

@adamtheturtle

Copy link
Copy Markdown
Owner

Summary

  • Handle onMoveCommand / Play-Pause / Menu on tvOS
  • Make result rows focusable and keep focus in sync with selectedIndex
  • Document Apple TV navigation in KeyboardNavigation.md

Test plan

  • swift test

Closes #120.

Made with Cursor

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e056e02. Configure here.

else { return }

selectedIndex = index
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote navigation double-steps selection

High Severity

onMoveCommand always calls move(by:) even when a result row already has focus, while those rows are also .focusable() and onChange(of: focusedResultID) updates selectedIndex. One Siri Remote swipe can advance the highlight twice—focus moves to the neighbor and move(by:) steps again—so browsing results overshoots. The comment notes moves are meant to nudge selection when focus is on the search field, but that condition is not enforced.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e056e02. Configure here.

@adamtheturtle
adamtheturtle merged commit 57cf2b4 into main Aug 23, 2026
7 of 8 checks passed
@adamtheturtle
adamtheturtle deleted the fix/issue-120 branch August 23, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tvOS support lacks navigation

1 participant