-
Notifications
You must be signed in to change notification settings - Fork 292
Automatic upgrade check broken #2290
Copy link
Copy link
Closed
Labels
C: Back-endIssues related to the Node.js back-endIssues related to the Node.js back-endD: easyStraightforward issues, small time commitmentStraightforward issues, small time commitmentI: minorLow, impact, low priority bugsLow, impact, low priority bugsS: mergedCompleted, reviewed, and merged issuesCompleted, reviewed, and merged issuesT: bug
Milestone
Metadata
Metadata
Assignees
Labels
C: Back-endIssues related to the Node.js back-endIssues related to the Node.js back-endD: easyStraightforward issues, small time commitmentStraightforward issues, small time commitmentI: minorLow, impact, low priority bugsLow, impact, low priority bugsS: mergedCompleted, reviewed, and merged issuesCompleted, reviewed, and merged issuesT: bug
The code assumes the GitHub API returns releases in reverse-chronological order, which is not always the case (first noticed in v0.7.0). These need to be sorted first.
Users are therefore forced to enter a specific tag to upgrade until this is fixed.
Update: the GitHub API sorts the release data by an arbitrary ID value, so this issue is only replicable when you've created releases out of order. In our case: created
v0.7.0draft, created and releasedv0.6.4&v0.6.5releases, releasedv0.7.0. Asv0.7.0was created before thev0.6.*, it appears earlier.