Asset tags are not preserved on import

[canstudios-nicolaw]

Expected Behaviour

If I export a course which contains assets that have tags then the imported assets should have the same tags.

Actual Behaviour

The imported assets do not have any tags.

Steps to Reproduce

1. Create a course which contains an asset which has a tag
2. Export the course. In the assets.json you will be able to see the tag
3. Import the course. The imported asset will not have any tags.

The problem is with the import side rather than the export side. In importsource.js there is an addAssets function which contains line var tags = formTags.slice(); I believe this is the problem.

Versions

• Authoring Tool Version: 0.10.0
• Framework Version: 4.3.0

[canstudios-nicolaw]

I don't think this has been fixed.

Relevant code is in importsource.js:

          var assetJson = assetsJson[assetName];
          var tags = [];

          if (assetJson) {
            logger.log('error', 'assetsJson present')
            assetTitle = assetJson.title;
            assetDescription = assetJson.description;

            assetJson.tags.forEach(function(tag) {

              const tagTitle = tag.title;
              const warn = (error) => logger.log('warn', `Failed to create asset tag '${tagTitle}' ${error}`);

              if(!tagTitle) return warn(new Error('Tag has no title'));

              app.contentmanager.getContentPlugin('tag', function(error, plugin) {
                if(error) return warn(error);
                plugin.create({ title: tagTitle }, function(error, record) { // @note retrieves if tag already exists
                  if(error) return warn(error);
                  tags.push(record._id);
                });
              });
            });
          }
          var fileMeta = {
            oldId: assetId,
            title: assetTitle,
            type: mime.getType(assetName),
            size: fileStat["size"],
            filename: assetName,
            description: assetDescription,
            path: assetPath,
            tags: tags,
            repository: repository,
            createdBy: app.usermanager.getCurrentUser()._id
          };

The problem seems to be that the tags do get pushed to the array but after the empty tags array has already been set in fileMeta. The result is that the tags get imported but they aren't attached to the assets.

[dancgray]

@canstudios-nicolaw do you have an example of how to reproduce? I can see why you might be getting the issue but TBH cannot reproduce it myself. I have made a change here that might fix it.

[canstudios-nicolaw]

@dancgray It looks to me like it's a race condition, I had the issue every time but perhaps I was just unlucky! I think this fix might work - I will give it a test now.

[canstudios-nicolaw]

@dancgray Yes that has worked :) Please could you PR it and we will get it in 0.10.2