Skip to content

Change absolute url to relative; fix for subfolder reverse proxy.#2261

Merged
taylortom merged 5 commits intoadaptlearning:release/bugpatchfrom
oscarsiles:master
Apr 17, 2019
Merged

Change absolute url to relative; fix for subfolder reverse proxy.#2261
taylortom merged 5 commits intoadaptlearning:release/bugpatchfrom
oscarsiles:master

Conversation

@oscarsiles
Copy link
Copy Markdown
Contributor

I have made some changes to change all absolute paths to relative ones, which allows the authoring tool to be used on any subfolder rather than the server root. Fixes #2137.

I have tested it myself in both environments (root and subfolder) and all tasks appear to work correctly, but I would be happy for others to test it as well to make sure there are no issues.

@oscarsiles
Copy link
Copy Markdown
Contributor Author

oscarsiles commented Mar 5, 2019

I'm not quite sure why CI build is failing, but would love if someone has some time to find the issue!

EDIT: I have run the tests on my workstation, and while it fails on the first run, running tests a second time comes back as all clear. Travis CI bug?

Copy link
Copy Markdown
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I'm yet to fit in any testing but could this be one that's slipped through the net?

@oscarsiles
Copy link
Copy Markdown
Contributor Author

It seems to be, but I cannot find anywhere to access that link? From my understanding it should navigate to the URL on course creation, but it appears to already work. I will remove the leading slash for consistency.

@taylortom taylortom added this to the Bug patch #2 milestone Apr 8, 2019
@taylortom taylortom changed the base branch from master to release/bugpatch April 9, 2019 10:50
@taylortom
Copy link
Copy Markdown
Member

Thanks for this @oscarsiles, we're hoping to get this merged in the next patch release.

Copy link
Copy Markdown
Contributor

@canstudios-nicolaw canstudios-nicolaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@taylortom taylortom merged commit afe4a80 into adaptlearning:release/bugpatch Apr 17, 2019
@oscarsiles
Copy link
Copy Markdown
Contributor Author

Just a quick update, it seems no Shared Courses are displaying on my install with this fix (Server Error 500). I will hopefully have another fix soon (if it hasn't been flagged already).

@canstudios-nicolaw
Copy link
Copy Markdown
Contributor

Hi @oscarsiles thanks for the update. Are you able to share the details of the 500 error?

We are hoping to release soon so need to make a decision as to whether this fix goes into the imminent release or the one after.

Thanks

@oscarsiles
Copy link
Copy Markdown
Contributor Author

oscarsiles commented May 8, 2019

The error appears when you click on "Shared Courses" and the course list is blank. From Chrome console:

GET https://XXX/adapt/api/shared/course?search%5Btitle%5D=.*.*&operators%5Bskip%5D=0&operators%5Blimit%5D=1&operators%5Bsort%5D%5Btitle%5D=1 500 (Internal Server Error) - origin.js?20190508090112845:213

Checking the URL, it returns "ContentPermissionError".

@canstudios-nicolaw
Copy link
Copy Markdown
Contributor

Thank you for your quick response.

@tomgreenfield do you have somewhere you are able to confirm this?

@tomgreenfield
Copy link
Copy Markdown
Contributor

Hi, I'm unable to replicate this on my local (root) instance with the latest release/bugpatch branch.

@oscarsiles
Copy link
Copy Markdown
Contributor Author

I've just tested it on a root URL, and it works fine there. I have probably missed something that was added in 0.7.x...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants