Change absolute url to relative; fix for subfolder reverse proxy.#2261
Change absolute url to relative; fix for subfolder reverse proxy.#2261taylortom merged 5 commits intoadaptlearning:release/bugpatchfrom oscarsiles:master
Conversation
|
I'm not quite sure why CI build is failing, but would love if someone has some time to find the issue! EDIT: I have run the tests on my workstation, and while it fails on the first run, running tests a second time comes back as all clear. Travis CI bug? |
tomgreenfield
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I'm yet to fit in any testing but could this be one that's slipped through the net?
|
It seems to be, but I cannot find anywhere to access that link? From my understanding it should navigate to the URL on course creation, but it appears to already work. I will remove the leading slash for consistency. |
|
Thanks for this @oscarsiles, we're hoping to get this merged in the next patch release. |
|
Just a quick update, it seems no Shared Courses are displaying on my install with this fix (Server Error 500). I will hopefully have another fix soon (if it hasn't been flagged already). |
|
Hi @oscarsiles thanks for the update. Are you able to share the details of the 500 error? We are hoping to release soon so need to make a decision as to whether this fix goes into the imminent release or the one after. Thanks |
|
The error appears when you click on "Shared Courses" and the course list is blank. From Chrome console:
Checking the URL, it returns "ContentPermissionError". |
|
Thank you for your quick response. @tomgreenfield do you have somewhere you are able to confirm this? |
|
Hi, I'm unable to replicate this on my local (root) instance with the latest release/bugpatch branch. |
|
I've just tested it on a root URL, and it works fine there. I have probably missed something that was added in 0.7.x... |
I have made some changes to change all absolute paths to relative ones, which allows the authoring tool to be used on any subfolder rather than the server root. Fixes #2137.
I have tested it myself in both environments (root and subfolder) and all tasks appear to work correctly, but I would be happy for others to test it as well to make sure there are no issues.