Skip to content

Resolves #2358 - allow rgba values to be set via ColourPicker input#2359

Merged
canstudios-nicolaw merged 1 commit intoadaptlearning:release/bugpatchfrom
danielstorey:issue/2358
Jun 17, 2019
Merged

Resolves #2358 - allow rgba values to be set via ColourPicker input#2359
canstudios-nicolaw merged 1 commit intoadaptlearning:release/bugpatchfrom
danielstorey:issue/2358

Conversation

@danielstorey
Copy link
Copy Markdown
Contributor

  • Fix error when a theme property has a select input type
  • Remove duplicate property from scaffoldColourPickerView

This checks the alpha value when saving a colour and saves the rgba value if less than 1.

- Fix error when a theme property has a select input type
- Remove duplicate property from scaffoldColourPickerView
@tomgreenfield tomgreenfield added this to the Bugpatch milestone Jun 10, 2019
@canstudios-nicolaw
Copy link
Copy Markdown
Contributor

@danielstorey Please can you edit this PR so that it points to release/bugpatch instead of master

@danielstorey danielstorey changed the base branch from master to release/bugpatch June 17, 2019 07:58
Copy link
Copy Markdown
Contributor

@canstudios-nicolaw canstudios-nicolaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@canstudios-nicolaw canstudios-nicolaw merged commit e2c250b into adaptlearning:release/bugpatch Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants