Prevent selects pushing button onto new line#2402
Merged
canstudios-nicolaw merged 2 commits intoadaptlearning:release/bugpatchfrom Aug 16, 2019
Merged
Prevent selects pushing button onto new line#2402canstudios-nicolaw merged 2 commits intoadaptlearning:release/bugpatchfrom
canstudios-nicolaw merged 2 commits intoadaptlearning:release/bugpatchfrom
Conversation
Contributor
tomgreenfield
left a comment
tomgreenfield
left a comment
There was a problem hiding this comment.
Would be nice to have this somehow only apply when both selects are in use? Only ask because it's now truncating a lot of our custom (non-editable) theme names.
Contributor
Author
|
Good point - I'll take a look |
tomgreenfield
approved these changes
Aug 8, 2019
canstudios-matth
approved these changes
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2361
Sets the size of the selects so that they don't push the button onto a new line and so that the size doesn't change and cause the button to jump around when selecting different themes.