Clear build folder on export and publish#2488
Merged
tomgreenfield merged 3 commits intoadaptlearning:release/bugpatchfrom Jan 30, 2020
Merged
Clear build folder on export and publish#2488tomgreenfield merged 3 commits intoadaptlearning:release/bugpatchfrom
tomgreenfield merged 3 commits intoadaptlearning:release/bugpatchfrom
Conversation
canstudios-nicolaw
added
T: bug
S: awaiting-review
dancgray
approved these changes
Jan 9, 2020
Contributor
|
Yet to give this a test but does/can this happen on a 'force rebuild' preview as well? |
Contributor
Author
|
You're right @tomgreenfield it does happen on preview (force or regular) as well. In fact I can't think of a situation in which we wouldn't want the build folder to be emptied. What do you think of moving that line out of the if statement? (Or just having this as it's own waterfall step?) |
Contributor
|
Not really sure about the normal, 'non-rebuild' preview - might be easier to leave that process untouched. |
tomgreenfield
approved these changes
Jan 14, 2020
Contributor
Author
|
@tomgreenfield I think it would be worth you approving again since I've committed since the last approval |
tomgreenfield
approved these changes
Jan 27, 2020
taylortom
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2235 & #2442.