Skip to content

fix(config): correct DefaultMode semantics and default to real weights#10

Merged
adcondev merged 2 commits into
fix/tuisfrom
copilot/sub-pr-9
Feb 10, 2026
Merged

fix(config): correct DefaultMode semantics and default to real weights#10
adcondev merged 2 commits into
fix/tuisfrom
copilot/sub-pr-9

Conversation

Copilot AI commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

The DefaultMode configuration field had an inverted comment ("false = test mode") and both environments defaulted to test mode with simulated weights instead of reading from actual hardware.

Configuration Changes:

  • Fixed DefaultMode comment to reflect actual semantics: true = test mode (simulated weights), false = real weights
  • Changed both local and remote environments to DefaultMode: false for real scale readings by default
// Before
DefaultMode bool // false = test mode (simulated weights)
// ...
"remote": {
    DefaultMode: true,  // Defaults to test mode
},

// After  
DefaultMode bool // true = test mode (simulated weights), false = real weights
// ...
"remote": {
    DefaultMode: false,  // Defaults to real weights
},

Both deployment environments now read from actual scale hardware by default, with test mode available via runtime configuration updates when needed.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: adcondev <38170282+adcondev@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix logging naming for Bascula service fix(config): correct DefaultMode semantics and default to real weights Feb 9, 2026
Copilot AI requested a review from adcondev February 9, 2026 23:58
@adcondev adcondev requested a review from Copilot February 10, 2026 16:31
@adcondev adcondev added the enhancement New feature or request label Feb 10, 2026
@adcondev adcondev moved this to In progress in POS RED2000 Feb 10, 2026
@adcondev adcondev marked this pull request as ready for review February 10, 2026 16:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects the meaning of the DefaultMode configuration flag and updates environment defaults so the daemon starts in real hardware mode rather than simulated/test mode.

Changes:

  • Fix Environment.DefaultMode comment to match actual behavior (true = test/simulated, false = real hardware).
  • Change both remote and local environment defaults to DefaultMode: false (real weights by default).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adcondev adcondev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@adcondev adcondev merged commit 82a7737 into fix/tuis Feb 10, 2026
6 checks passed
@adcondev adcondev deleted the copilot/sub-pr-9 branch February 10, 2026 16:40
@github-project-automation github-project-automation Bot moved this from In progress to Done in POS RED2000 Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants