fix(config): correct DefaultMode semantics and default to real weights#10
Merged
Conversation
Co-authored-by: adcondev <38170282+adcondev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix logging naming for Bascula service
fix(config): correct DefaultMode semantics and default to real weights
Feb 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects the meaning of the DefaultMode configuration flag and updates environment defaults so the daemon starts in real hardware mode rather than simulated/test mode.
Changes:
- Fix
Environment.DefaultModecomment to match actual behavior (true= test/simulated,false= real hardware). - Change both
remoteandlocalenvironment defaults toDefaultMode: false(real weights by default).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DefaultModeconfiguration field had an inverted comment ("false = test mode") and both environments defaulted to test mode with simulated weights instead of reading from actual hardware.Configuration Changes:
DefaultModecomment to reflect actual semantics:true = test mode (simulated weights), false = real weightslocalandremoteenvironments toDefaultMode: falsefor real scale readings by defaultBoth deployment environments now read from actual scale hardware by default, with test mode available via runtime configuration updates when needed.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.