test(logger): improve testing for FilteredLogger#30
Conversation
- Refactor `FilteredLogger` to use `io.Writer` instead of `*os.File` to allow dependency injection. - Add `internal/logging/logging_test.go` to test log filtering logic. - Verify filtering of non-critical messages in non-verbose mode. - Verify all messages are logged in verbose mode. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
👋 Thanks for opening this PR, @adcondev! Here's what will happen next:
Please make sure:
|
⚡ Benchmark ResultsTo add benchmarks, create functions starting with |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adcondev
changed the title
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactored
FilteredLoggerininternal/logging/logging.goto acceptio.Writerinterface, enabling testing withbytes.Buffer. Added comprehensive unit tests ininternal/logging/logging_test.gocovering verbose and non-verbose modes, and critical vs non-critical message filtering.PR created automatically by Jules for task 9828601996824816041 started by @adcondev