fix(ci): pre-install @adcp/client + bump readiness window for v3 storyboard#448
Merged
fix(ci): pre-install @adcp/client + bump readiness window for v3 storyboard#448
Conversation
…yboard The v3 reference seller storyboard CI job was failing with "Upstream mock failed to start within 30s". Root cause: ``npx -y -p @adcp/client@latest`` runs a fresh npm install on every CI run (~50MB of deps + metadata build), eating most of the 30s readiness budget before the JS process even starts. Two changes: 1. Pre-install ``@adcp/client@latest`` in a separate step BEFORE the readiness loop. The npm cache (now enabled on actions/setup-node) makes subsequent runs fast. 2. Bump readiness from 30s (60×0.5s) to 60s (120×0.5s). Even with the pre-install, GHA-hosted runner cold starts can be variable. This unblocks the path to promoting the v3 ref seller storyboard job to required. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v3 reference seller storyboard CI job has been failing intermittently with "Upstream mock failed to start within 30s". Root cause:
npx -y -p @adcp/client@latestruns a fresh npm install on every CI run (~50MB of deps + metadata build), eating most of the 30s readiness budget before the JS process even starts.Changes
@adcp/client@latestvianpm install -gin a separate step BEFORE the readiness loopactions/setup-nodeso subsequent runs are fastTest plan
This unblocks the path to promoting the v3 ref seller storyboard job to required.
🤖 Generated with Claude Code