Conversation
…to live codemod The "270 files / 161 test-collection failures" paragraph read as a current migration-difficulty forecast; it is actually a v4.0-era worst-case baseline. v4.3+ alias coverage and codemod improvements have materially reduced finding counts. Adds temporal context and redirects adopters to run the codemod against their own tree for a current estimate, so the note ages gracefully without becoming a second stale number. Closes #520 https://claude.ai/code/session_0138z8359JAkARZJWfmBLprE
Pull figures outside the parenthetical and make the disclaimer a standalone sentence — resolves pre-PR review finding that em-dash + semicolon nested inside a parenthetical was hard to parse (human and agent readers both). No meaning change; intent and all data points preserved. https://claude.ai/code/session_0138z8359JAkARZJWfmBLprE
…k note Nit from pre-PR review: 'before alias coverage and codemod improvements' was vague about timing. 'Before subsequent' makes the temporal arc explicit. https://claude.ai/code/session_0138z8359JAkARZJWfmBLprE
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #520
The
MIGRATION_v3_to_v4.mdguide cited "270 files scanned, 161 test-collection failures" as if these were current migration difficulty benchmarks. They are real adopter data, but from the v4.0 release period — before subsequent alias coverage and codemod improvements that materially reduced finding counts at v4.3+. The misleading framing caused an adopter to expect worse migration pain than they actually hit.This PR anchors the data point temporally ("at v4.0 release"), adds a standalone disclaimer sentence clarifying the figures reflect initial-release tooling, and redirects adopters to run the codemod against their own tree for a current count — so the note ages gracefully without becoming another stale number.
The cascade mechanics explanation (import re-export amplification, ordering steps) is unchanged; those are version-independent.
What was tested
ruff check .— not applicable (no Python files changed)mypy src/— not applicable (no Python files changed)Pre-PR review
Noted nits not fixed (pre-existing): the
salesagent re-exported through…line is technically a sentence fragment; the two-idea paragraph could use a blank-line break between the data point and the cascade narrative. Neither was introduced by this PR.Session: https://claude.ai/code/session_0138z8359JAkARZJWfmBLprE
Generated by Claude Code