Skip to content

docs(migration): anchor v3→v4 adopter numbers to v4.0 release, point to live codemod #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 3 commits into from
May 4, 2026
Merged

docs(migration): anchor v3→v4 adopter numbers to v4.0 release, point to live codemod #522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a75d9ed
docs(migration): anchor v3→v4 adopter numbers to v4.0 release, point …
claude May 4, 2026
c01742f
docs(migration): restructure adopter-feedback paragraph for clarity
claude May 4, 2026
62477e9
docs(migration): clarify 'subsequent' improvements in adopter-feedbac…
claude May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions MIGRATION_v3_to_v4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,16 @@ dependencies = [

## Fix removed-type imports first — they cascade

Real-adopter feedback (salesagent v3→v4 experiment, 270 files scanned, 161
test-collection failures): consumers tend to centralize SDK imports in one
schema module, so a single broken import there crashes test collection across
the whole codebase. salesagent re-exported through `src/core/schemas/_base.py`
— **one missing `FormatCategory` import there cascaded into ~140 test failures
during pytest collect-only**, and stubbing it revealed the next ~140-test
cascade from `BrandManifest`, then the next from the `generated_poc` reach-ins.
Real-adopter feedback (salesagent v3→v4 experiment at v4.0 release): 270 files
scanned, 161 test-collection failures. These figures reflect tooling at initial
release, before subsequent alias coverage and codemod improvements; run the codemod against
your own tree to see your actual count. Consumers tend to centralize SDK imports
in one schema module, so a single broken import there crashes test collection
across the whole codebase. salesagent re-exported through
`src/core/schemas/_base.py` — **one missing `FormatCategory` import there
cascaded into ~140 test failures during pytest collect-only**, and stubbing it
revealed the next ~140-test cascade from `BrandManifest`, then the next from
the `generated_poc` reach-ins.

The codemod's static finding count understates this by 100x+. To minimize the
felt blast radius, work in this order:
Expand Down
Loading